• Fizz@lemmy.nz
    link
    fedilink
    arrow-up
    84
    arrow-down
    1
    ·
    1 year ago

    No matter how many times I read this I have no idea what’s going on. Can someone explain this like I’m 3

    • Prismey@sh.itjust.works
      link
      fedilink
      arrow-up
      143
      ·
      1 year ago

      A girl read documentation and see that all the titles are underlined with -, but one of the letter isn’t underlined like the others (that’s the lonely s). Then she asks the person doing the commit to fix it and they fix it together.

    • MJBrune@beehaw.org
      link
      fedilink
      arrow-up
      50
      ·
      1 year ago

      So in the documentation they had

      1.9 Ext4 file system parameters
      ------------------------------
      

      As you can see the ‘s’ doesn’t get a ‘-’ under it. So they changed the documentation to:

      1.9 Ext4 file system parameters
      -------------------------------
      

      so the ‘s’ in parameters gets a dash under it.

      this seems to be the standard as everywhere else the dashes go for the same length of characters as the above line. Example:

      2.0 /proc/consoles
      ------------------
      

      The little girl said the ‘s’ in parameters is sad because it didn’t get the dash under it and it was all alone. So they added the dash.

    • jsveiga@sh.itjust.works
      link
      fedilink
      arrow-up
      16
      arrow-down
      1
      ·
      edit-2
      1 year ago

      See the first red box in the ext4 documentation text? The underline dashes don’t go up to the last letter (s).

      4 year old girl said the “s” was sad because of that, aunt submitted a patch to fix that, and it was accepted.

    • Infamousblt [any]@hexbear.net
      link
      fedilink
      English
      arrow-up
      14
      ·
      edit-2
      1 year ago

      The line of code (well, documentation in the code) used to look like something like this (I’m not sure if this formatting will work on mobile, sorry):

      The code ends with an s

      ----------------------

      And after her changes it looks like this:

      The code ends with an s

      ------------------------

      See how I added an extra - in that second line? That makes the S happier because now it also has a - below it like all the other letters. This also just generally makes that line more consistent with other spots in the code. So it’s not a bad change. It doesn’t do anything really but making your code format nice, easy to read, and consistent is usually important in programming so although it doesn’t do anything tangible it’s still a valuable change!

    • redawl@sh.itjust.works
      link
      fedilink
      arrow-up
      6
      ·
      1 year ago

      The first red box shows that the dotted line underneith the text doesn’t go all the way to the s in the text above. In the other red box, the dotted line goes all the way.

      The neice submitted a patch to add the missing line.

    • fubo@lemmy.world
      link
      fedilink
      arrow-up
      4
      ·
      1 year ago

      She spotted that there was a missing - in the underline for a heading in a piece of documentation, and her parent helped her submit a fix.

  • Flarp@kbin.social
    link
    fedilink
    arrow-up
    43
    ·
    1 year ago

    lazy to not submit a unit test to check for this throughout the repo. That girl isn’t going anywhere with that kind of work ethic

  • SootyChimney [any]@hexbear.net
    link
    fedilink
    English
    arrow-up
    34
    ·
    1 year ago

    Though slightly cliche, this just feels right. That niece has learned a great lesson about how collaborating to improve things is always possible, and that open-source relies on everyone doing their bit.

    • ReakDuck@lemmy.ml
      link
      fedilink
      arrow-up
      25
      ·
      1 year ago

      Welcome to Open Source software where its ok to help once and never again. Thats actually not even a bad thing.

      Imagine there is this one project that kicks everyones autism and has many issues. But only a team of 100 people is allowed to change its code. I’d rather want the world to change the code and make it improve for everyones liking. Even if it was just one commit and never again.

      • themoonisacheese@sh.itjust.works
        link
        fedilink
        arrow-up
        4
        ·
        1 year ago

        I “maintain” (I don’t) a thing I made 5 years ago for playing Minecraft. I no longer care about it because I don’t play anymore, but over the years many people have submitted pull requests to improve it to the point there is very few miles of code that are from me.

    • Mereo@lemmy.ca
      link
      fedilink
      arrow-up
      7
      ·
      1 year ago

      Think about it this way. It’s a social project. Everybody does their part to help. If they can only help once, great! If they have time to help a few hours a week, great! If they want to help in a significant way, great!

      With these social projects, the most important thing is to help, even once.

      • MJBrune@beehaw.org
        link
        fedilink
        arrow-up
        2
        ·
        1 year ago

        Except for decades if you tried to help but you were even so slightly wrong the lead developer would yell and swear at you and tell you to never program again. Social projects need better leaders than what Linus was.

        • GizmoLion@kbin.social
          link
          fedilink
          arrow-up
          1
          ·
          1 year ago

          You’re right he can be a bit crass without needing to be. The outcome of his methods is exemplary, though.

          • MJBrune@beehaw.org
            link
            fedilink
            arrow-up
            2
            ·
            1 year ago

            At every place I worked the motto for hiring has always been, you could be the best person in the industry for this job but if you’re an asshole we don’t want to hire you. I can’t agree more with that. I don’t care how good his code is, if he’s an asshole then I don’t want to submit to his project. He’s like the Elon Musk of Linux. We don’t need to support those types of assholes. I wouldn’t do paid work for Twitter or Telsa because of Elon, I ain’t going to do work for Linux for Linus.

            Also, one person is not the life of a project but they can define the project’s culture. If Linus wants to write Linux all himself with a cult of followers then sure, he can have a slightly more successful version of TempleOS. He’s still not going to attract the world of developers out there that are far better as a whole and more successful as a whole than him. He proudly defines and encourages this toxic culture and it keeps very talented developers away. Frankly, someone should fork the Linux kernel and create a non-toxic work environment for people.

            • GizmoLion@kbin.social
              link
              fedilink
              arrow-up
              2
              ·
              1 year ago

              Why not be the change you wish to see, then? Fork it, and surely they will come.

              That or Linus’ work is of high enough quality that people are willing to put up with his crass behavior.

              Also, somewhat unrelated, but comparing Linus to Elon is a nonstarter. Elon has money, but contributes little more than ego past that. Linus, on the other hand, actually gets his hands dirty. I don’t care for his behavior, but I do respect someone who actually does the work.