Hey all, I made a Firefox extension (signed by Mozilla) specifically to add Show/Hide Child Comments functionality similar to how RES had it (where the parent comment is still visible).

It’s not very useful, but I could use some feedback on tightening up the Javascript. I’m not a JS beginner, but I know I can do better, so any tips are welcome!

EDIT: Also, if anyone has any suggestions for the extension, I’m open to those as well.

  • cyberic@discuss.tchncs.de
    link
    fedilink
    arrow-up
    12
    ·
    3 months ago

    I really miss the RES feature of keyboard navigation (mainly j, k, to move between posts.) Thanks for making this!

      • towerful@programming.dev
        link
        fedilink
        arrow-up
        1
        ·
        edit-2
        3 months ago

        I haven’t tried this yet, but I’m excited for it’s potential.
        Having a bunch of RES-like enhancements with toggles, and the ability for users to (manually & anonymously, via a button) “submit” their preferences to a central database would be an awesome way to gather Lemmy user feedback on various upcoming features.
        This would give fantastic options for Lemmy developers to implement, popularity of features, and easy ways for users to choose what they want (as long as any permanent Lemmy implementations come with an enable/disable toggle)

    • kn0wmad1c@programming.devOP
      link
      fedilink
      English
      arrow-up
      3
      ·
      3 months ago

      Hey, just a heads up - I updated the extension to add some rudimentary keyboard navigation. Your j and k are there, and also you can use m to toggle the child comments for the selected comment.

      • Baizey@feddit.dk
        link
        fedilink
        arrow-up
        4
        ·
        edit-2
        3 months ago

        If you wanna tighten up your extension build process feel free to steal my build setup :) (https://github.com/Baizey/UniversalAutomaticCurrencyConverter )

        It’s using esbuild and I’m using it to bundle for both chrome and Firefox separately (they expect slightly different manifest files), has multi entry points support (background, content, options and popup) and builds for ts/js

        • Lemminary@lemmy.world
          link
          fedilink
          arrow-up
          1
          ·
          3 months ago

          bundle for both chrome and Firefox

          You’re a true warrior tolerating that. It gives me headaches.

          • Baizey@feddit.dk
            link
            fedilink
            arrow-up
            2
            ·
            3 months ago

            Oh yeah, but the current manifest v3 difference between Firefox and Chrome is peanuts compared to when I had to have custom logic around regex as they didn’t support the same set of regex specs. Fuck that

        • kn0wmad1c@programming.devOP
          link
          fedilink
          English
          arrow-up
          1
          ·
          edit-2
          3 months ago

          Your repo made me want to convert the extension to TS, which I’ve never written in before.

          So I did that, and I’m getting to learn a new syntax! Thanks :D