Be…before I go. Could you approve all my experimental PRs?
Real story, I have a branch that’s been open for four years at my company to add support for nested postgres transactions. It works flawlessly… but we, the senior devs, are uncertain if it’s a power that would be used responsibly by the juniors. If I’m going to walk into the light, I’m going to make sure there’s a badass explosion behind me.
I’m in the niche of niches by using vsc with a vim plugin while being a dvorak user. I rely on vim’s langmap feature to get anywhere, but people implementing vim emulators blissfully ignore accessibility like that. So I went and implemented langmap in vsc’s vim plugin myself. It has minimal intervention into the existing codebase and a bunch of other people have been wishing for this for years. Yet, when it comes to merging… Silence.
I disagree.
Real story, I have a branch that’s been open for four years at my company to add support for nested postgres transactions. It works flawlessly… but we, the senior devs, are uncertain if it’s a power that would be used responsibly by the juniors. If I’m going to walk into the light, I’m going to make sure there’s a badass explosion behind me.
I’ve got one for a vscode feature (middle mouse click for go-to definition) that I want but the maintainers don’t think it would be used.
I’m in the niche of niches by using vsc with a vim plugin while being a dvorak user. I rely on vim’s langmap feature to get anywhere, but people implementing vim emulators blissfully ignore accessibility like that. So I went and implemented langmap in vsc’s vim plugin myself. It has minimal intervention into the existing codebase and a bunch of other people have been wishing for this for years. Yet, when it comes to merging… Silence.
Can’t you just open source your fork? I mean yeah it does suck but still. I’ve been in the same place and it does suck when they won’t take your PR.
I try to use middle click for definition in vscode so often because you can do that in jetbrains IDEs…
Give this PR some love then. It works and it’s magical but they don’t seem interested in merging it in. https://github.com/microsoft/vscode/pull/154465
Godspeed my friend. 10/10 I would use that irresponsibly.